-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Child scope of container is not visualized on dot graph #402
Labels
Comments
This is a valid feature request. I believe the DOT representation wasn't rewritten when we rewrote Dig's internal graph representation when we worked on the Scope feature. |
Merged
@sywhang should we close this issue or you want to add here info about future improvement that was discussed in pull request? |
I'll leave this open for now since we need some more visual improvements. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Child scope of container is not visualized on dot graph.
To Reproduce
c := dig.New()
c.Provide(NewFirstComponent)
child := c.Scope("test_scope")
child.Provide(NewSecondComponent)
dig.Visualize(c, os.Stdout)
Expected behavior
I expect to see child scope along with
NewSecondComponent
but I only seeNewFirstComponent
.Additional context
Dig version:
v1.17.1
Go Playground: https://go.dev/play/p/lhYAIUlfsPr
DOT:
Graph image:
The text was updated successfully, but these errors were encountered: