Call variadic constructors without arguments #123
Conversation
Dig constructors may now be variadic functions. These functions will be called with their dependencies as usual and no arguments will be passed for the variadic arguments. So a constructor `New(*Foo, *Bar, ...Option) *Baz` will be treated as `New(*Foo, *Bar) *Baz`. See #120 for more discussion.
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
==========================================
+ Coverage 99.6% 99.61% +0.01%
==========================================
Files 3 3
Lines 254 263 +9
==========================================
+ Hits 253 262 +9
Misses 1 1
Continue to review full report at Codecov.
|
dig.go
Outdated
| @@ -389,8 +396,15 @@ func newNode(k key, ctor interface{}, ctype reflect.Type) (*node, error) { | |||
|
|
|||
| // Retrieves the dependencies for a constructor | |||
| func getConstructorDependencies(ctype reflect.Type) ([]edge, error) { | |||
| numArgs := ctype.NumIn() | |||
There was a problem hiding this comment.
lets extract into a function since the code and comment appears twice
|
|
||
| require.NoError(t, c.Invoke(func(a *A, as ...*A) { | ||
| require.NotNil(t, a, "A must not be nil") | ||
| require.True(t, a == gaveA, "A must match") |
There was a problem hiding this comment.
require.Equal on pointers dereferences and compares value. Because this is an empty type (struct{}), that will always be true. == on pointers compares the pointer value to verify that it's the same instance of the object.
| }), "failed to provide A") | ||
|
|
||
| require.NoError(t, c.Provide(func() []*A { | ||
| panic("[]*A constructor must not be called.") |
There was a problem hiding this comment.
I was sort of trying to stay consistent with existing tests that use panic.
Plus with require.FailNow, you now have to have an empty return statement to satisfy the compiler.
I can change this if you feel strongly about this.
* Only install dependencies once for examples Fixes uber-go#118
Dig constructors may now be variadic functions. These functions will be
called with their dependencies as usual and no arguments will be passed
for the variadic arguments.
So a constructor
New(*Foo, *Bar, ...Option) *Bazwill be treated asNew(*Foo, *Bar) *Baz.See #120 for more discussion.