[WIP] Support simultanous name and group tags #381
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Dig issue:
#380
In order to support Fx feature requests
uber-go/fx#998
uber-go/fx#1036
We need to be able to drop the restriction, both in terms of options dig.Name and dig.Group and dig.Out struct annotations on
name
andgroup
being mutually exclusive.In a shortly upcoming PR, this can then be exploited to populate value group maps where the 'name' tag becomes the key of a map[string][T]
For now, please do not merge.