-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple ResultTags annotations #1210
Labels
Comments
miyamo2
added a commit
to miyamo2/fx
that referenced
this issue
Jul 10, 2024
Closes uber-go#1210 This commit makes it possible to specify multiple `fx.ResultTags` annotations in a single `fx.Annotate` call. ```go fx.Provide( fx.Annotate( func() *bytes.Buffer { return bytes.NewBuffer([]byte("Hello!")) }, fx.ResultTags(`name:"a"`), fx.ResultTags(`name:"b"`), fx.ResultTags(`name:"c"`), ), ) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As multiple
As
annotations are supported, it would make sense to support multiple ResultTag annotations.Currently this code fails with
cannot apply more than one line of ResultTags
A work-around is possible by providing multiple copies of the same instance of a type, however it is less intuitive.
Is this a breaking change?
It should not be a breaking change as nothing (sans tests) should rely on app failure for multiple result tag annotations.
The text was updated successfully, but these errors were encountered: