Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade minimum version of Go to 1.22 #275

Merged
merged 5 commits into from
Oct 5, 2024
Merged

Conversation

yuxincs
Copy link
Contributor

@yuxincs yuxincs commented Aug 23, 2024

Go 1.23 is recently released and this PR bumps our minimum version to Go 1.22, along with a few other house keeping changes.

@yuxincs yuxincs marked this pull request as ready for review August 23, 2024 15:25
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.91%. Comparing base (ccdcbe7) to head (2fb8418).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
+ Coverage   87.69%   87.91%   +0.22%     
==========================================
  Files          66       66              
  Lines        7939     7935       -4     
==========================================
+ Hits         6962     6976      +14     
+ Misses        796      785      -11     
+ Partials      181      174       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 23, 2024

Golden Test

Warning

❌ NilAway errors reported on stdlib are different.

3211 errors on base branch (main, ccdcbe7)
3211 errors on test branch (a9fed4e)

Diffs
+ /opt/hostedtoolcache/go/1.23.2/x64/src/sync/atomic/value.go:1:1: INTERNAL ERROR(s):
+ nilaway_assertion_analyzer: nilaway_function_analyzer: analyzing function AppendSeq at /opt/hostedtoolcache/go/1.23.2/x64/src/slices/iter.go:49.1: backpropagation across node (/opt/hostedtoolcache/go/1.23.2/x64/src/slices/iter.go:50:6) of type *ast.AssignStmt failed for reason: unrecognized type of rhs in range statement: iter.Seq[E]
+ /opt/hostedtoolcache/go/1.23.2/x64/src/sync/atomic/value.go:1:1: INTERNAL ERROR(s):
+ nilaway_assertion_analyzer: nilaway_function_analyzer: analyzing function ExampleChunk at /opt/hostedtoolcache/go/1.23.2/x64/src/slices/example_test.go:388.1: backpropagation across node (/opt/hostedtoolcache/go/1.23.2/x64/src/slices/example_test.go:405:6) of type *ast.AssignStmt failed for reason: unrecognized type of rhs in range statement: iter.Seq[slices_test.People]
+ analyzing function TestValues at /opt/hostedtoolcache/go/1.23.2/x64/src/slices/iter_test.go:58.1: backpropagation across node (/opt/hostedtoolcache/go/1.23.2/x64/src/slices/iter_test.go:66:7) of type *ast.AssignStmt failed for reason: unrecognized type of rhs in range statement: iter.Seq[int]
+ analyzing function TestChunkRange at /opt/hostedtoolcache/go/1.23.2/x64/src/slices/iter_test.go:275.1: backpropagation across node (/opt/hostedtoolcache/go/1.23.2/x64/src/slices/iter_test.go:278:6) of type *ast.AssignStmt failed for reason: unrecognized type of rhs in range statement: iter.Seq[[]int]
+ /opt/hostedtoolcache/go/1.23.2/x64/src/sync/atomic/value.go:1:1: INTERNAL ERROR(s):
+ nilaway_assertion_analyzer: nilaway_function_analyzer: analyzing function ExamplePreorder at /opt/hostedtoolcache/go/1.23.2/x64/src/go/ast/example_test.go:143.1: backpropagation across node (/opt/hostedtoolcache/go/1.23.2/x64/src/go/ast/example_test.go:159:6) of type *ast.AssignStmt failed for reason: unrecognized type of rhs in range statement: iter.Seq[go/ast.Node]
+ analyzing function TestPreorderBreak at /opt/hostedtoolcache/go/1.23.2/x64/src/go/ast/walk_test.go:14.1: backpropagation across node (/opt/hostedtoolcache/go/1.23.2/x64/src/go/ast/walk_test.go:28:6) of type *ast.AssignStmt failed for reason: unrecognized type of rhs in range statement: iter.Seq[go/ast.Node]
+ /opt/hostedtoolcache/go/1.23.2/x64/src/sync/atomic/value.go:1:1: INTERNAL ERROR(s):
+ nilaway_assertion_analyzer: nilaway_function_analyzer: analyzing function TestKeys at /opt/hostedtoolcache/go/1.23.2/x64/src/maps/iter_test.go:32.1: backpropagation across node (/opt/hostedtoolcache/go/1.23.2/x64/src/maps/iter_test.go:42:7) of type *ast.AssignStmt failed for reason: unrecognized type of rhs in range statement: iter.Seq[int]
+ analyzing function TestValues at /opt/hostedtoolcache/go/1.23.2/x64/src/maps/iter_test.go:52.1: backpropagation across node (/opt/hostedtoolcache/go/1.23.2/x64/src/maps/iter_test.go:62:7) of type *ast.AssignStmt failed for reason: unrecognized type of rhs in range statement: iter.Seq[int]
- /opt/hostedtoolcache/go/1.23.2/x64/src/internal/cpu/cpu_x86.go:1:1: INTERNAL ERROR(s):
- nilaway_assertion_analyzer: nilaway_function_analyzer: analyzing function AppendSeq at /opt/hostedtoolcache/go/1.23.2/x64/src/slices/iter.go:49.1: backpropagation across node (/opt/hostedtoolcache/go/1.23.2/x64/src/slices/iter.go:50:6) of type *ast.AssignStmt failed for reason: unrecognized type of rhs in range statement: iter.Seq[E]
- /opt/hostedtoolcache/go/1.23.2/x64/src/internal/cpu/cpu_x86.go:1:1: INTERNAL ERROR(s):
- nilaway_assertion_analyzer: nilaway_function_analyzer: analyzing function ExampleChunk at /opt/hostedtoolcache/go/1.23.2/x64/src/slices/example_test.go:388.1: backpropagation across node (/opt/hostedtoolcache/go/1.23.2/x64/src/slices/example_test.go:405:6) of type *ast.AssignStmt failed for reason: unrecognized type of rhs in range statement: iter.Seq[slices_test.People]
- analyzing function TestValues at /opt/hostedtoolcache/go/1.23.2/x64/src/slices/iter_test.go:58.1: backpropagation across node (/opt/hostedtoolcache/go/1.23.2/x64/src/slices/iter_test.go:66:7) of type *ast.AssignStmt failed for reason: unrecognized type of rhs in range statement: iter.Seq[int]
- analyzing function TestChunkRange at /opt/hostedtoolcache/go/1.23.2/x64/src/slices/iter_test.go:275.1: backpropagation across node (/opt/hostedtoolcache/go/1.23.2/x64/src/slices/iter_test.go:278:6) of type *ast.AssignStmt failed for reason: unrecognized type of rhs in range statement: iter.Seq[[]int]
- /opt/hostedtoolcache/go/1.23.2/x64/src/internal/cpu/cpu_x86.go:1:1: INTERNAL ERROR(s):
- nilaway_assertion_analyzer: nilaway_function_analyzer: analyzing function ExamplePreorder at /opt/hostedtoolcache/go/1.23.2/x64/src/go/ast/example_test.go:143.1: backpropagation across node (/opt/hostedtoolcache/go/1.23.2/x64/src/go/ast/example_test.go:159:6) of type *ast.AssignStmt failed for reason: unrecognized type of rhs in range statement: iter.Seq[go/ast.Node]
- analyzing function TestPreorderBreak at /opt/hostedtoolcache/go/1.23.2/x64/src/go/ast/walk_test.go:14.1: backpropagation across node (/opt/hostedtoolcache/go/1.23.2/x64/src/go/ast/walk_test.go:28:6) of type *ast.AssignStmt failed for reason: unrecognized type of rhs in range statement: iter.Seq[go/ast.Node]
- /opt/hostedtoolcache/go/1.23.2/x64/src/internal/cpu/cpu_x86.go:1:1: INTERNAL ERROR(s):
- nilaway_assertion_analyzer: nilaway_function_analyzer: analyzing function TestKeys at /opt/hostedtoolcache/go/1.23.2/x64/src/maps/iter_test.go:32.1: backpropagation across node (/opt/hostedtoolcache/go/1.23.2/x64/src/maps/iter_test.go:42:7) of type *ast.AssignStmt failed for reason: unrecognized type of rhs in range statement: iter.Seq[int]
- analyzing function TestValues at /opt/hostedtoolcache/go/1.23.2/x64/src/maps/iter_test.go:52.1: backpropagation across node (/opt/hostedtoolcache/go/1.23.2/x64/src/maps/iter_test.go:62:7) of type *ast.AssignStmt failed for reason: unrecognized type of rhs in range statement: iter.Seq[int]

Copy link
Contributor

@sonalmahajan15 sonalmahajan15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yuxincs yuxincs merged commit 045b340 into main Oct 5, 2024
9 checks passed
@yuxincs yuxincs deleted the yuxincs/upgrade-go-version branch October 5, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants