Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip runtime and some zap frames in stacktraces #311

Merged
merged 6 commits into from
Mar 7, 2017
Merged

Skip runtime and some zap frames in stacktraces #311

merged 6 commits into from
Mar 7, 2017
+91 −40

Commits on Mar 7, 2017

  1. Clean up stacktrace

    @bufdev
    bufdev authored and Akshay Shah committed Mar 7, 2017
    Configuration menu
    Copy the full SHA
    bfe67f6 View commit details
    Browse the repository at this point in the history

  2. Use strings.HasPrefix instead of skip callers for takeStacktrace

    @bufdev
    bufdev authored and Akshay Shah committed Mar 7, 2017
    Configuration menu
    Copy the full SHA
    d1eb377 View commit details
    Browse the repository at this point in the history

  3. Update per comments

    @bufdev
    bufdev authored and Akshay Shah committed Mar 7, 2017
    Configuration menu
    Copy the full SHA
    7c29d89 View commit details
    Browse the repository at this point in the history

  4. Update after comments

    @bufdev
    bufdev authored and Akshay Shah committed Mar 7, 2017
    Configuration menu
    Copy the full SHA
    bf6975f View commit details
    Browse the repository at this point in the history

  5. Do not skip go.uber.org/zap calls when taking a stacktrace

    @bufdev
    bufdev authored and Akshay Shah committed Mar 7, 2017
    Configuration menu
    Copy the full SHA
    311ad66 View commit details
    Browse the repository at this point in the history

  6. Remove some now-unnecessary changes

    Akshay Shah committed Mar 7, 2017
    Configuration menu
    Copy the full SHA
    e48738f View commit details
    Browse the repository at this point in the history