Workflow event status badge #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adhityamamallan
requested changes
Sep 3, 2024
...history/workflow-history-event-status-badge/workflow-history-event-status-badge.constants.ts
Outdated
Show resolved
Hide resolved
...ow-history/workflow-history-event-status-badge/workflow-history-event-status-badge.styles.ts
Outdated
Show resolved
Hide resolved
...workflow-history/workflow-history-event-status-badge/workflow-history-event-status-badge.tsx
Show resolved
Hide resolved
...low-history/workflow-history-event-status-badge/workflow-history-event-status-badge.types.ts
Outdated
Show resolved
Hide resolved
...history/workflow-history-event-status-badge/workflow-history-event-status-badge.constants.ts
Outdated
Show resolved
Hide resolved
adhityamamallan
requested changes
Sep 3, 2024
...ow-history/workflow-history-event-status-badge/workflow-history-event-status-badge.styles.ts
Show resolved
Hide resolved
...ews/workflow-history/workflow-history-event-status-badge/helpers/get-badge-container-size.ts
Show resolved
Hide resolved
src/views/workflow-history/workflow-history-event-status-badge/helpers/get-badge-icon-size.ts
Show resolved
Hide resolved
adhityamamallan
approved these changes
Sep 3, 2024
| }, | ||
| [WORKFLOW_EVENT_STATUS.WAITING]: { | ||
| color: $theme.colors.black, | ||
| backgroundColor: $theme.colors.backgroundSecondary, |
There was a problem hiding this comment.
minor nit: backgroundSecondary is slightly different from the background gray we use in cadence-web
There was a problem hiding this comment.
seem like the docs is not reflecting the correct value
There was a problem hiding this comment.
Actually i found that the designs has backgroundSecondary as #F3F3F3 everywhere.
While our implementation has them as #F6F6F6.
Updated the value in the theme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Badge to represent activity status.
Status values:
screenshot
Fix tests:
snapshot files are by default removed if there are no matching test files for them. Since we have multiple test project setup, each test project can remove the snapshot files for other projects. To avoid this issue
.snapextension was changed to.snapshotto avoid other projects from processing the browser snapshots