Workflow page error message #670
Conversation
* Init commit * more commit * Add more changes * Add tests * clean up code * Init queries UI * Add unit tests * Fix unsaved merge conflict * Fix tests and merge conflicts again * update snapshot * Fix snapshot * Reorder some props in tile * resolve comments * Fix tests * Fix tests and make design responsive * Remove snapshots * Update tests for tile input
…NC-9155/timeline-load-more
…NC-9155/workflow-page-error-msg
| @@ -48,9 +49,9 @@ export default function WorkflowPageHeader({ | |||
| </StyledLink> | |||
| <div className={cls.breadcrumbItemContainer}> | |||
| {runId} | |||
| <Suspense> | |||
| <ReactErrorBoundary fallbackRender={() => null}> | |||
There was a problem hiding this comment.
Isn't a suspense the same thing in this situation?
Also, you should use the ErrorBoundary component we wrote, since it has extras like logging.
There was a problem hiding this comment.
This is what i though initially but seems like suspense only handles the loading fallback, while errors crashes the whole page.
I wanted to omit logging for it as the error is already logged in the page content.
But Actually i can use the other error boundary and pass omitLogging to it
| @@ -19,7 +18,7 @@ export default async function WorkflowPage({ params, children }: Props) { | |||
| cluster={decodedParams.cluster} | |||
| /> | |||
| <WorkflowPageTabs /> | |||
| <PageSection>{children}</PageSection> | |||
| {children} | |||
There was a problem hiding this comment.
If you're removing PageSection here, we need to add it to every workflow tab. Did you make the change in History?
There was a problem hiding this comment.
Yes, also i will be making changes later along with the virtual list to handle use cases like query page expand the whole page
Summary
Screenshots
not found
generic error
