Change noisy frontend poll timeout log to debug level (#5725)

uber · Mar 5, 2024 · 768cb11 · 768cb11
1 parent 7de6d18
commit 768cb11
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/common/util.go b/common/util.go
@@ -613,7 +613,7 @@ func ValidateLongPollContextTimeout(
  return err
  }
  if timeout < CriticalLongPollTimeout {
- logger.Warn("Context timeout is lower than critical value for long poll API.",
+ logger.Debug("Context timeout is lower than critical value for long poll API.",
  tag.WorkflowHandlerName(handlerName), tag.WorkflowPollContextTimeout(timeout))
  }
  return nil

diff --git a/common/util_test.go b/common/util_test.go
@@ -1460,7 +1460,7 @@ func TestValidateLongPollContextTimeout(t *testing.T) {
  t.Run("context timeout is set, but less than CriticalLongPollTimeout", func(t *testing.T) {
  logger := new(log.MockLogger)
  logger.On(
- "Warn",
+ "Debug",
  "Context timeout is lower than critical value for long poll API.",
  // we can't mock time between deadline and now, so we just check it as it is
  mock.Anything,

diff --git a/service/frontend/api/handler.go b/service/frontend/api/handler.go
@@ -430,7 +430,7 @@ func (wh *WorkflowHandler) PollForActivityTask(
  if err := common.ValidateLongPollContextTimeout(
  ctx,
  "PollForActivityTask",
- wh.GetThrottledLogger(),
+ wh.GetThrottledLogger().WithTags(tag.WorkflowDomainName(domainName), tag.WorkflowTaskListName(pollRequest.GetTaskList().GetName())),
  ); err != nil {
  return nil, err
  }
@@ -478,7 +478,7 @@ func (wh *WorkflowHandler) PollForActivityTask(
  if err := common.ValidateLongPollContextTimeout(
  ctx,
  "PollForActivityTask",
- wh.GetThrottledLogger(),
+ wh.GetThrottledLogger().WithTags(tag.WorkflowDomainName(domainName), tag.WorkflowTaskListName(pollRequest.GetTaskList().GetName())),
  ); err != nil {
  return &types.PollForActivityTaskResponse{}, nil
  }
@@ -544,7 +544,7 @@ func (wh *WorkflowHandler) PollForDecisionTask(
  if err := common.ValidateLongPollContextTimeout(
  ctx,
  "PollForDecisionTask",
- wh.GetThrottledLogger(),
+ wh.GetThrottledLogger().WithTags(tag.WorkflowDomainName(domainName), tag.WorkflowTaskListName(pollRequest.GetTaskList().GetName())),
  ); err != nil {
  return nil, err
  }
@@ -598,7 +598,7 @@ func (wh *WorkflowHandler) PollForDecisionTask(
  if err := common.ValidateLongPollContextTimeout(
  ctx,
  "PollForDecisionTask",
- wh.GetThrottledLogger(),
+ wh.GetThrottledLogger().WithTags(tag.WorkflowDomainName(domainName), tag.WorkflowTaskListName(pollRequest.GetTaskList().GetName())),
  ); err != nil {
  return &types.PollForDecisionTaskResponse{}, nil
  }