Emit number of task list managers started (#3929)

* Emit number of task list managers started
uber · Feb 3, 2021 · e895640 · e895640
1 parent bbfd674
commit e895640
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/common/metrics/defs.go b/common/metrics/defs.go
@@ -1960,6 +1960,7 @@ const (
  RemoteToLocalMatchPerTaskListCounter
  RemoteToRemoteMatchPerTaskListCounter
  PollerPerTaskListCounter
+ TaskListManagersGauge
 
  NumMatchingMetrics
 )
@@ -2441,6 +2442,7 @@ var MetricDefs = map[ServiceIdx]map[int]metricDefinition{
  RemoteToLocalMatchPerTaskListCounter: {metricName: "remote_to_local_matches_per_tl", metricRollupName: "remote_to_local_matches"},
  RemoteToRemoteMatchPerTaskListCounter: {metricName: "remote_to_remote_matches_per_tl", metricRollupName: "remote_to_remote_matches"},
  PollerPerTaskListCounter: {metricName: "poller_count_per_tl", metricRollupName: "poller_count"},
+ TaskListManagersGauge: {metricName: "tasklist_managers", metricType: Gauge},
  },
  Worker: {
  ReplicatorMessages: {metricName: "replicator_messages"},

diff --git a/service/matching/matchingEngine.go b/service/matching/matchingEngine.go
@@ -197,6 +197,10 @@ func (e *matchingEngineImpl) getTaskListManager(taskList *taskListID,
  return nil, err
  }
  e.taskLists[*taskList] = mgr
+ e.metricsClient.Scope(metrics.MatchingTaskListMgrScope).UpdateGauge(
+ metrics.TaskListManagersGauge,
+ float64(len(e.taskLists)),
+ )
  e.taskListsLock.Unlock()
  err = mgr.Start()
  if err != nil {
@@ -218,6 +222,10 @@ func (e *matchingEngineImpl) removeTaskListManager(id *taskListID) {
  e.taskListsLock.Lock()
  defer e.taskListsLock.Unlock()
  delete(e.taskLists, *id)
+ e.metricsClient.Scope(metrics.MatchingTaskListMgrScope).UpdateGauge(
+ metrics.TaskListManagersGauge,
+ float64(len(e.taskLists)),
+ )
 }
 
 // AddDecisionTask either delivers task directly to waiting poller or save it into task list persistence.