Release current workflow lock on create as zombie #4085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 027d0c8a-764f-4f1d-b8eb-90c0483cdfa1
💛 - Coveralls |
yycptt
approved these changes
Mar 29, 2021
github-actions
bot
force-pushed
the
zombie_reapply
branch
from
e38d447
to
659e0d4
Compare
yux0
added a commit
that referenced
this pull request
Mar 30, 2021
yux0
added a commit
to yux0/cadence
that referenced
this pull request
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Release current workflow lock on create as zombie
Why?
When creating workflow as zombie, the zombie wf may trigger event reapply to the current workflow run. It requires releasing the lock to avoid dead lock.
How did you test it?
Local test, a functional test will be add to cover this case.
Potential risks