Fix flacky integration tests #4094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkolodezny
reviewed
Mar 30, 2021
| @@ -613,7 +615,7 @@ func (s *IntegrationSuite) TestQueryWorkflow_Consistent_PiggybackQuery() { | |||
| } else if previousStartedEventID > 0 { | |||
| for _, event := range history.Events[previousStartedEventID:] { | |||
| if *event.EventType == types.EventTypeWorkflowExecutionSignaled { | |||
| handledSignal = true | |||
| handledSignal.Store(true) | |||
There was a problem hiding this comment.
nit: do we need to be sure to set it just once? then please consider sync.Once
There was a problem hiding this comment.
I don't think it needs to be set just once.
mkolodezny
reviewed
Mar 30, 2021
| @@ -961,7 +964,7 @@ func (s *IntegrationSuite) TestQueryWorkflow_Consistent_BlockedByStarted_NonStic | |||
| if *event.EventType == types.EventTypeWorkflowExecutionSignaled { | |||
| // wait for some time to force decision task to stay in started state while query is issued | |||
| <-time.After(5 * time.Second) | |||
| handledSignal = true | |||
| handledSignal.Store(true) | |||
mkolodezny
reviewed
Mar 30, 2021
| @@ -1149,7 +1153,7 @@ func (s *IntegrationSuite) TestQueryWorkflow_Consistent_NewDecisionTask_Sticky() | |||
| if *event.EventType == types.EventTypeWorkflowExecutionSignaled { | |||
| // wait for some time to force decision task to stay in started state while query is issued | |||
| <-time.After(5 * time.Second) | |||
| handledSignal = true | |||
| handledSignal.Store(true) | |||
mkolodezny
approved these changes
Mar 30, 2021
yux0
pushed a commit
to yux0/cadence
that referenced
this pull request
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
The tests have race conditions.
How did you test it?
Potential risks
Release notes
Documentation Changes