Update Master cluster to Primary cluster #4185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG.md
Outdated
| @@ -11,7 +11,8 @@ You can find a list of previous releases on the [github releases](https://github | |||
| - Added GRPC support. Cadence server will accept requests on both TChannel and GRPC. With dynamic config flag `system.enableGRPCOutbound` it will also switch to GRPC communication internally between server components. | |||
|
|
|||
| ### Fixed | |||
| - Fixed a bug where an error message is always displayed in Cadence UI `persistence max qps reached for list operations` on the workflow list screen (#3958) | |||
| - Fixed a bug where an error message is always displayed in Cadence UI `persistence max qps reached for list operations` on the workflow list screen (#3958) | |||
There was a problem hiding this comment.
This was a wrong fix. I just talked to Justin about it. He will make a fix in web using retry.
| // all clusters can do domain failover | ||
| PrimaryClusterName string `yaml:"primaryClusterName"` |
There was a problem hiding this comment.
Just a convention that we introduced breaking changes in configuration -- can we have a version being compatible with warning logs? Likely 0.22.0. And then in 0.23.0 we will remove MasterClusterName completely.
There was a problem hiding this comment.
Yes. This versio is backward compatible. Added a logging message.
CHANGELOG.md
Outdated
| @@ -11,7 +11,7 @@ You can find a list of previous releases on the [github releases](https://github | |||
| - Added GRPC support. Cadence server will accept requests on both TChannel and GRPC. With dynamic config flag `system.enableGRPCOutbound` it will also switch to GRPC communication internally between server components. | |||
|
|
|||
| ### Fixed | |||
| - Fixed a bug where an error message is always displayed in Cadence UI `persistence max qps reached for list operations` on the workflow list screen (#3958) | |||
| - Replace masterClusterName config with primaryClusterName(#4185) | |||
There was a problem hiding this comment.
Is that for release notes for next release? Maybe putting it more clear that users should update their config
longquanzheng
approved these changes
May 8, 2021
… into remove_master_cluster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Update Master cluster to Primary cluster
Why?
Update Master cluster to Primary cluster
How did you test it?
server starts
Potential risks
N/A
Release notes
Documentation Changes
N/A