Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check identity length before RespondDecisionTaskCompleted to history #4215

Merged
merged 1 commit into from
May 24, 2021

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented May 24, 2021

What changed?

  • Check identity length before RespondDecisionTaskCompleted to history
  • Apply error normalization for the error returned by GetHistoryClient().RespondDecisionTaskCompleted() call.

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

@yycptt yycptt requested review from yux0, demirkayaender and a team May 24, 2021 17:46
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8a63a75f-0808-49a5-b1c1-79364c216817

  • 5 of 7 (71.43%) changed or added relevant lines in 1 file are covered.
  • 46 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-0.007%) to 59.969%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/frontend/workflowHandler.go 5 7 71.43%
Files with Coverage Reduction New Missed Lines %
common/types/shared.go 1 28.72%
host/archivalTest.go 1 98.18%
service/history/execution/mutable_state_task_refresher.go 1 75.29%
service/history/task/task.go 1 82.52%
common/task/fifoTaskScheduler.go 2 82.47%
common/task/weightedRoundRobinTaskScheduler.go 2 89.64%
service/history/execution/mutable_state_builder.go 2 69.79%
service/history/handler.go 2 46.67%
service/history/task/transfer_active_task_executor.go 2 69.66%
common/types/history.go 4 24.69%
Totals Coverage Status
Change from base Build c7912ee6-b287-4758-b353-669b944a7bbf: -0.007%
Covered Lines: 88504
Relevant Lines: 147584

💛 - Coveralls

@yycptt yycptt merged commit edfb9ed into uber:master May 24, 2021
@yycptt yycptt deleted the fix-identity-len-check branch May 24, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants