Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly catch errors in ldflag-gathering and fail the build #5539

Merged
merged 18 commits into from
Jan 8, 2024
Merged

Properly catch errors in ldflag-gathering and fail the build #5539

merged 18 commits into from
Jan 8, 2024

Commits on Dec 23, 2023

  1. Properly catch errors in ldflag-gathering and fail the build 

    The dubious-ownership issue in CI appears to be happening here too,
and might be why some builds have "unknown" as their commit SHAs.

Building this locally properly fails to build binaries when it cannot
be gathered, and includes the data when it can:
```
VERSION:
   CLI feature version: 1.7.0
   Release version: v1.2.7-prerelease2-dirty
   Build commit: 2023-12-22T20:30:21+00:00-d4d205fe3
```
    @Groxx
    Groxx committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    d253b28 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Merge branch 'master' into ldflags

    @Groxx
    Groxx committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    d8f55e7 View commit details
    Browse the repository at this point in the history

  2. #!/bin/bash for consistency

    @Groxx
    Groxx committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    09ab367 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2024

  1. ci fix maybe?

    @Groxx
    Groxx committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    07165ee View commit details
    Browse the repository at this point in the history

  2. remove old safe-directory fix

    @Groxx
    Groxx committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    62c3d2e View commit details
    Browse the repository at this point in the history

  3. Revert "ci fix maybe?" 

    This reverts commit 07165ee.
(testing)
    @Groxx
    Groxx committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    13f8ca8 View commit details
    Browse the repository at this point in the history

  4. checking which command fails

    @Groxx
    Groxx committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    90802f8 View commit details
    Browse the repository at this point in the history

  5. aaaargh can shellcheck warn about this maybe

    @Groxx
    Groxx committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    5ebf52a View commit details
    Browse the repository at this point in the history

  6. add shellcheck

    @Groxx
    Groxx committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    dfde429 View commit details
    Browse the repository at this point in the history

  7. fix queue

    @Groxx
    Groxx committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    35ec15e View commit details
    Browse the repository at this point in the history

  8. glob?

    @Groxx
    Groxx committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    e2e0386 View commit details
    Browse the repository at this point in the history

  9. abandon shellcheck step attempt

    @Groxx
    Groxx committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    6d41d87 View commit details
    Browse the repository at this point in the history

  10. add shellcheck to make lint, fix warnings

    @Groxx
    Groxx committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    372998f View commit details
    Browse the repository at this point in the history

  11. Reapply "ci fix maybe?" 

    This reverts commit 13f8ca8.
    @Groxx
    Groxx committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    ec5e9a6 View commit details
    Browse the repository at this point in the history

  12. drop shellcheck completely, not available in docker image currently

    @Groxx
    Groxx committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    a54d4db View commit details
    Browse the repository at this point in the history

  13. try dockerfile safe.directory instead

    @Groxx
    Groxx committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    ce43d89 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Merge branch 'master' into ldflags

    @Groxx
    Groxx committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    9ac9b70 View commit details
    Browse the repository at this point in the history

  2. remove unnecessary export

    @Groxx
    Groxx committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    0e2a5ac View commit details
    Browse the repository at this point in the history