Added tests for visibility sampling wrapper #5564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3vilhamster
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
3vilhamster
force-pushed
the
visibility-sampling-wrapper
branch
from
87da005
to
84e28ae
Compare
| ok, _ := rateLimiter.GetToken(0, 1) | ||
| if ok { | ||
| p.logger.Debug("List API request consumed QPS token", tag.WorkflowDomainName(domain), tag.Name(callerFuncName(2))) | ||
| p.logger.Debug("List API request consumed QPS token", tag.WorkflowDomainName(domain), tag.Name(method)) |
There was a problem hiding this comment.
good idea getting rid of the not-future-safe callerFuncName here
3vilhamster
force-pushed
the
visibility-sampling-wrapper
branch
from
b7b3609
to
2e23e13
Compare
taylanisikdemir
approved these changes
Dec 29, 2023
3vilhamster
force-pushed
the
visibility-sampling-wrapper
branch
from
2e23e13
to
a9329e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I've refactored visibility sampling manager:
There are no logical changes.
Why?
Improving test coverage
How did you test it?
Unit tests/integration tests.
Potential risks
Release notes
Documentation Changes