Add cache for workflow specific in memory data #5594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rkflowid combination
jakobht
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Pull Request Test Coverage Report for Build 018d1c9b-c743-4e7e-93cb-acba6240defc
💛 - Coveralls |
… there is no need for the wfcache to handle locking
|
LGTM. do we plan to add observability with metrics/logging in a follow up diff? |
I think that makes sense, I didn't want to add more things in this PR, just wanted to establish the foundation and get that reviewed, to make sure we have the same expectations |
sankari165
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Adding a struct for storing in memory workflow specific data. It will first be used for storing workflow specific rate limiters, so we can rate limit too many requests to the same workflowID.
In the future it could store e.g. the current state of the workflow (running, terminated), query answers etc.
Why?
This is part of the general workflow specific rate limits project
How did you test it?
Unit tests
Potential risks
No risk, just adding the struct
Release notes
Documentation Changes