Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed useless metrics tag from the workflowIDcache #5651

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Removed useless metrics tag from the workflowIDcache #5651

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion service/history/workflowcache/cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ func (c *wfCache) allow(domainID string, workflowID string, rateLimitType rateLi
}

c.metricsClient.
Scope(metrics.HistoryClientWfIDCacheScope, metrics.DomainTag(domainName)).
Scope(metrics.HistoryClientWfIDCacheScope).
UpdateGauge(metrics.WorkflowIDCacheSizeGauge, float64(c.lru.Size()))

// Locking is not needed because both getCacheItem and the rate limiter are thread safe
Expand Down