Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for GetDLQAckLevel and UpdateDLQAckLevel #5740

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

abhishekj720
Copy link
Contributor

Description:
Unit tests for the GetDLQAckLevel and UpdateDLQAckLevel methods.

Why?:
Adequate test coverage for these methods is crucial for ensuring the reliability of our DLQ management.

How did you test it?
unit tests

Potential risks
No risks as it only contains tests.

@abhishekj720 abhishekj720 enabled auto-merge (squash) March 6, 2024 23:06
@abhishekj720 abhishekj720 merged commit 3b5dc47 into uber:master Mar 6, 2024
17 of 18 checks passed
@abhishekj720 abhishekj720 deleted the testrq5 branch March 6, 2024 23:22
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018e15fa-c517-4778-9bef-b241dc725c47

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 74 unchanged lines in 16 files lost coverage.
  • Overall coverage decreased (-0.02%) to 63.749%

Files with Coverage Reduction New Missed Lines %
service/matching/matcher.go 1 91.07%
client/history/client.go 2 35.78%
common/persistence/historyManager.go 2 66.67%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/util.go 2 91.69%
service/history/handler/handler.go 2 49.59%
service/history/task/transfer_standby_task_executor.go 2 87.42%
service/matching/taskListManager.go 2 79.7%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 63.03%
service/history/task/fetcher.go 3 86.6%
Totals Coverage Status
Change from base Build 018e15f5-d98e-489b-923c-e2bf40fc977e: -0.02%
Covered Lines: 93455
Relevant Lines: 146599

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants