Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing metric tag for GetTaskListSizeRequest #5939

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Add missing metric tag for GetTaskListSizeRequest #5939

merged 1 commit into from
Apr 25, 2024

Conversation

Shaddoll
Copy link
Contributor

What changed?
Add missing metric tag for GetTaskListSizeRequest

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

@Shaddoll Shaddoll enabled auto-merge (squash) April 25, 2024 17:50
@Shaddoll Shaddoll merged commit 4dd0045 into uber:master Apr 25, 2024
18 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018f165d-6023-42c4-9933-0d4b98877085

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 8 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.04%) to 67.76%
Files with Coverage Reduction New Missed Lines %
common/task/fifo_task_scheduler.go 2 85.57%
service/matching/taskListManager.go 2 80.4%
service/matching/matcher.go 2 90.72%
common/membership/hashring.go 2 84.69%
Totals Coverage Status
Change from base Build 018f127b-cd0f-43c3-b47a-35b58b7623db: 0.04%
Covered Lines: 99393
Relevant Lines: 146683
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidporter-id-au davidporter-id-au davidporter-id-au approved these changes

@neil-xie neil-xie Awaiting requested review from neil-xie neil-xie is a code owner

@Groxx Groxx Awaiting requested review from Groxx Groxx is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@agautam478 agautam478 Awaiting requested review from agautam478

@jakobht jakobht Awaiting requested review from jakobht jakobht is a code owner

@3vilhamster 3vilhamster Awaiting requested review from 3vilhamster 3vilhamster is a code owner

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@taylanisikdemir taylanisikdemir Awaiting requested review from taylanisikdemir taylanisikdemir is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shaddoll @coveralls @davidporter-id-au