Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move err check before log message #6073

Merged
merged 2 commits into from
Jun 3, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions service/frontend/api/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -3146,14 +3146,13 @@ func (wh *WorkflowHandler) ListAllWorkflowExecutions(
WorkflowSearchValue: listRequest.WorkflowSearchValue,
},
)

wh.GetLogger().Debug("List all workflows",
tag.WorkflowDomainName(listRequest.GetDomain()), tag.WorkflowListWorkflowFilterByType)

if err != nil {
return nil, err
}

wh.GetLogger().Debug("List all workflows",
tag.WorkflowDomainName(listRequest.GetDomain()), tag.WorkflowListWorkflowFilterByType)

resp = &types.ListAllWorkflowExecutionsResponse{}
resp.Executions = persistenceResp.Executions
resp.NextPageToken = persistenceResp.NextPageToken
Expand Down
Loading