Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tasklist type tag for all metrics from tasklistmgr scope #6180

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

Shaddoll
Copy link
Contributor

What changed?
Add tasklist type tag for all metrics from tasklistmgr scope

Why?
We need to differentiate metrics from activity tasklist and decision tasklist

How did you test it?

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.75%. Comparing base (4a51fb4) to head (eba09fc).

Additional details and impacted files
Files Coverage Δ
service/matching/tasklist/task_list_manager.go 64.07% <100.00%> (-0.18%) ⬇️
service/matching/tasklist/task_reader.go 73.88% <66.66%> (+0.75%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a51fb4...eba09fc. Read the comment docs.

@Shaddoll Shaddoll merged commit ebda4b1 into uber:master Jul 22, 2024
20 checks passed
@Shaddoll Shaddoll deleted the metrics branch July 22, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants