Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wf-Diagnostics] fix activity input for diagnostics workflow #6247

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

sankari165
Copy link
Contributor

What changed?
Updating input structs for all activities in diagnostics workflow

Why?
Activity Input fields were not serialisable

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.94%. Comparing base (14ae23e) to head (5d7dfcc).
Report is 6 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
service/worker/diagnostics/activities.go 100.00% <100.00%> (ø)
service/worker/diagnostics/workflow.go 87.09% <100.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14ae23e...5d7dfcc. Read the comment docs.

@sankari165 sankari165 merged commit 5575487 into uber:master Aug 26, 2024
20 checks passed
@sankari165 sankari165 deleted the CDNC-10131-inputfix branch August 26, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants