Update error package to 10.4.0 #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
rvil
approved these changes
Aug 16, 2023
Comment on lines
+24
to
+27
| class UnfulfilledRequirement extends SError {}; | ||
| class InvalidState extends SError {}; | ||
| class Misconfigured extends SError {}; | ||
| class ResponseError extends SError {}; |
There was a problem hiding this comment.
Did we have an official node version we supported on this package? The class keyword was added on Node v4.3.2
There was a problem hiding this comment.
Might be a good idea to setup engines in package.json
albertyw
force-pushed
the
update-error
branch
2 times, most recently
from
9c1ffb2
to
76bb158
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old error package is outdated. This updates to the current version of the error package.
Fixes #102
Depends on #105