update cibw #359
Merged
update cibw #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fa8f7c9.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #359 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 319 319
=========================================
Hits 319 319 ☔ View full report in Codecov by Sentry. |
isaacbrodsky
approved these changes
Apr 14, 2024
|
A potential way to clean up the build matrix: pypa/cibuildwheel#1261 |
|
Seems like we don't lose anything by dropping |
|
Building wheels is by far the slowest part of h3-py development, so I'm interested in anything we can do that might speed it up. We have one solution already, which is to avoid building wheels when a PR is in draft form, but that doesn't help for PRs like this one that are focused on building wheels :) |
isaacbrodsky
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pypa/[email protected]cp*-musllinux_x86_64into individual jobs because it is the slowest