Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Yaru*Row widgets #200

Closed
Feichtmeier opened this issue Sep 12, 2022 · 4 comments
Closed

Remove Yaru*Row widgets #200

Feichtmeier opened this issue Sep 12, 2022 · 4 comments

Comments

@Feichtmeier
Copy link
Member

They are basically only material rows with something inside. We should move them back to settings

@jpnurmi
Copy link
Member

jpnurmi commented Sep 23, 2022

How about moving them to packages/yaru_settings or such in the settings repo to have them separate from the app? We could still easily enough reuse them to implement in-app settings in other projects:

yaru_settings:
  git:
    url: https:/ubuntu-flutter-community/settings.git
    path: packages/yaru_settings

@Feichtmeier
Copy link
Member Author

That's a nice idea :)!

@Feichtmeier
Copy link
Member Author

Feichtmeier commented Oct 3, 2022

Damn, there is one cool feature I have forgotten about with the yaru rows. This enabled/disabled flag also changes the text colour of child widgets. Which is a pretty cool feature imo, combined with the boring stuff that wouldn't alone justify those widgets.
Hm 🤔

@Feichtmeier
Copy link
Member Author

Damn, there is one cool feature I have forgotten about with the yaru rows. This enabled/disabled flag also changes the text colour of child widgets. Which is a pretty cool feature imo, combined with the boring stuff that wouldn't alone justify those widgets. Hm thinking

I close this for now, thanks to JP for pimping up all those widgets

@Feichtmeier Feichtmeier reopened this Oct 6, 2022
Feichtmeier pushed a commit that referenced this issue Oct 6, 2022
These will be made available in settings/packages/yaru_settings.

Solves: #200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants