Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify pathing to obey push dirs for node autoinsertion #844

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

bdngo
Copy link
Contributor

@bdngo bdngo commented Feb 28, 2024

This fixes a small bug where when allowing the flowgraph tool to autogenerate the auxiliary action nodes, it would not obey the user-specified parent.push_dir. Instead, the generated auxiliary node pulls from parent.push_dir and pushes to child.pull_dir.

Related PRs / Issues

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • Change to core Hammer
  • Change to a Hammer plugin
  • Other

Contributor Checklist:

  • Did you set master as the base branch?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you update the poetry.lock file if you updated the requirements in pyproject.toml?
  • (If applicable) Did you add a unit test demonstrating the PR?
  • (If applicable) Did you run this through the e2e integration tests?
  • (If applicable) Did you update the submodules in e2e/ if this feature depends on updated plugins?

@harrisonliew harrisonliew added this pull request to the merge queue Feb 28, 2024
Merged via the queue into master with commit 5897249 Feb 28, 2024
3 checks passed
@harrisonliew harrisonliew deleted the auto-auxiliary-fix branch February 28, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants