Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(injectTools): narrow down the UMD loader to window #387

Merged
merged 1 commit into from
Dec 12, 2022
Merged

fix(injectTools): narrow down the UMD loader to window #387

merged 1 commit into from
Dec 12, 2022

Conversation

ArnaudBuchholz
Copy link
Collaborator

FIX #386
Also fixed a typo

Co-authored-by: Sumesh Nair [email protected]

@arnaudbuchholz-sap @nair-sumesh
fix(injectTools): narrow down the UMD loader to window
fb9c5b7 
FIX #386
Also fixed a typo

Co-authored-by: Sumesh Nair <[email protected]>
@ArnaudBuchholz ArnaudBuchholz linked an issue Dec 9, 2022 that may be closed by this pull request
Sometimes browser.asControl fails with the error "cannot read properties of undefined (reading compare)" #386
Closed
@vobu
Copy link
Contributor

vobu commented Dec 12, 2022

thanks to you 2, @ArnaudBuchholz and @nair-sumesh, for tracking down this nasty 🐛 !
By the description of it in #386, this must have been a real bugger and taken a lot of time - 🙌
I'll retrigger the CI and see if we ran into false positives there.

vobu
vobu approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@vobu vobu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i salute you for digging into terserified source code

@vobu vobu merged commit 4f7994b into main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vobu vobu vobu approved these changes

@dominikfeininger dominikfeininger Awaiting requested review from dominikfeininger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sometimes browser.asControl fails with the error "cannot read properties of undefined (reading compare)"
3 participants
@ArnaudBuchholz @vobu @arnaudbuchholz-sap