Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bounces property for disabling over-scroll bouncing. #20

Merged
merged 2 commits into from
Mar 13, 2017

Conversation

msaps
Copy link
Member

@msaps msaps commented Mar 13, 2017

  • Add bounces property to PageboyViewController.
  • Add updateContentOffsetForBounceIfNeeded function to update contentOffset for bounces preference.

Resolves #19

- Add bounces property to PageboyViewController.
- Add updateContentOffsetForBounceIfNeeded function to update contentOffset for bounces preference.
@codecov
Copy link

codecov bot commented Mar 13, 2017

Codecov Report

Merging #20 into develop will increase coverage by 0.15%.
The diff coverage is 78.26%.

@@             Coverage Diff             @@
##           develop      #20      +/-   ##
===========================================
+ Coverage    73.11%   73.27%   +0.15%     
===========================================
  Files           13       13              
  Lines          729      752      +23     
===========================================
+ Hits           533      551      +18     
- Misses         196      201       +5
Impacted Files Coverage Δ
Sources/Pageboy/PageboyViewController.swift 73.58% <ø> (ø)
Sources/Pageboy/PageboyScrollDetection.swift 59.13% <71.42%> (+1%)
Sources/PageboyTests/PageboyTransitionTests.swift 90.06% <88.88%> (-0.08%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16bab2a...bd634ca. Read the comment docs.

@msaps msaps merged commit 96c4425 into develop Mar 13, 2017
@msaps msaps deleted the feature/bounces_property branch March 13, 2017 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant