Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain cycle #34

Closed
shitoexe opened this issue Apr 5, 2017 · 1 comment
Closed

Retain cycle #34

shitoexe opened this issue Apr 5, 2017 · 1 comment

Comments

@shitoexe
Copy link

shitoexe commented Apr 5, 2017

Hello. I have found retain cycle between PageboyViewController and PageboyAutoScroller. They keep each other in loadView method. Could you make handler property in PageboyAutoScroller as weak? Thank you.

open override func loadView() {
        super.loadView()
        
        self.autoScroller.handler = self
        self.setUpPageViewController()
    }
@msaps
Copy link
Member

msaps commented Apr 5, 2017

@shitoexe thanks for pointing this out! Now fixed and available in 1.0.1. 😄

@msaps msaps closed this as completed Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants