Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Index.atIndex -> Index.at #42

Merged
merged 1 commit into from
Apr 16, 2017
Merged

Conversation

muukii
Copy link
Contributor

@muukii muukii commented Apr 16, 2017

I've renamed following.
PageIndex.atIndex(index: Int) -> PageIndex.at(index: Int)

Then you can initialize it as follows.

.at(index: 3)

What do yo think?

@codecov
Copy link

codecov bot commented Apr 16, 2017

Codecov Report

Merging #42 into master will decrease coverage by 0.15%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
- Coverage   79.72%   79.56%   -0.16%     
==========================================
  Files          14       14              
  Lines         868      871       +3     
==========================================
+ Hits          692      693       +1     
- Misses        176      178       +2
Impacted Files Coverage Δ
Sources/Pageboy/PageboyViewController.swift 77.14% <50%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bcb633...2d29ac2. Read the comment docs.

@msaps msaps changed the base branch from master to develop April 16, 2017 17:37
@msaps msaps merged commit f9424f0 into uias:develop Apr 16, 2017
@msaps
Copy link
Member

msaps commented Apr 16, 2017

Thanks, I like it! 👍

@muukii
Copy link
Contributor Author

muukii commented Apr 16, 2017

@msaps
Thank you for the merge!

@muukii muukii deleted the muukii/naming-index branch April 16, 2017 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants