Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite scrolling issues. #44

Merged
merged 1 commit into from
Apr 22, 2017

Conversation

anlaital
Copy link
Contributor

There were a couple of issues when using scrollToPage on a pager that had isInfiniteScrollEnabled set to true.

  • .next used the wrong direction when animating from the last page to the first.
  • .previous did not work at all when trying to scroll from the first page to the last.

@codecov
Copy link

codecov bot commented Apr 22, 2017

Codecov Report

Merging #44 into master will decrease coverage by 0.57%.
The diff coverage is 18.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   79.88%   79.31%   -0.58%     
==========================================
  Files          14       14              
  Lines         890      899       +9     
==========================================
+ Hits          711      713       +2     
- Misses        179      186       +7
Impacted Files Coverage Δ
Sources/Pageboy/PageboyViewController.swift 74.45% <18.18%> (-2.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1782d1f...efd0390. Read the comment docs.

@msaps msaps changed the base branch from master to develop April 22, 2017 13:22
@msaps msaps merged commit cdbafc8 into uias:develop Apr 22, 2017
@msaps
Copy link
Member

msaps commented Apr 22, 2017

Thanks! 😄 I'll get this in the next release 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants