Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for initialization options #90

Closed
rainypixels opened this issue Jul 25, 2017 · 4 comments
Closed

Add support for initialization options #90

rainypixels opened this issue Jul 25, 2017 · 4 comments

Comments

@rainypixels
Copy link

rainypixels commented Jul 25, 2017

Apologies if I missed this, but it seems like there's no way to supply the third argument (options) for a PageboyViewController. This is really the only way to add space between pages via the UIPageViewControllerOptionInterPageSpacingKey option key.

Maybe initial support could be provided with an API similar to navigationOrientation?

public var interPageSpacing : CGFloat = 0 {
    didSet {
        guard self.pageViewController != nil else { return }
        self.setUpPageViewController(reloadViewControllers: false)
    }
}

This is an incredible library (thank you!) but the inability to specify space between pages is a bit of a dealbreaker right now. 😭

@msaps
Copy link
Member

msaps commented Jul 25, 2017

Hi,

I'll see if I can add support for both these parameters via properties ASAP. 👍

@msaps
Copy link
Member

msaps commented Jul 25, 2017

@rainypixels this is now available in 1.4.0 via the interPageSpacing property 😄

@msaps msaps closed this as completed Jul 25, 2017
@rainypixels
Copy link
Author

Well, that may be the fastest turnaround for a feature request that I've ever experienced! 🎉 🎉 🎉 🙌🏽 🙌🏽 🙌🏽 Huge thanks, @msaps! Truly.

(for reference, I am considering shipping pageboy in our upcoming app — digest.io)

@msaps
Copy link
Member

msaps commented Jul 25, 2017

@rainypixels glad to hear it, you’re welcome 😀 caught me at a good time!

Looks really cool, like the website! Feel free to raise any other issues/requests you come across when using Pageboy! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants