Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'public' modifier is redundant for * declared in a public extension #196

Merged
merged 2 commits into from
Feb 22, 2019
Merged

'public' modifier is redundant for * declared in a public extension #196

merged 2 commits into from
Feb 22, 2019

Conversation

Coeur
Copy link
Contributor

@Coeur Coeur commented Feb 22, 2019

Quite annoying to have all those Xcode warnings when using PageBoy.

screen shot 2019-02-22 at 10 07 56

@uias-bot
Copy link
Member

1 Warning
⚠️ Looks like you changed some source files, should there have been some tests added?

Generated by 🚫 Danger

@msaps
Copy link
Member

msaps commented Feb 22, 2019

@Coeur also nice 😄 - weirdly haven't ever had these warnings thrown.

@msaps msaps merged commit a28c604 into uias:master Feb 22, 2019
@Coeur Coeur deleted the redundancy branch February 22, 2019 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants