Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds getter UIPageViewController #223

Merged
merged 2 commits into from
Aug 5, 2019
Merged

Adds getter UIPageViewController #223

merged 2 commits into from
Aug 5, 2019

Conversation

ChristianSteffens
Copy link
Contributor

We needed to change the minimumNumberOfTouches for the panning gesture recognizer of the original UIPageViewController:

  • Adds public getter for UIPageViewController
  • Adds getter / setter for numberOfTouches for the underlying pageViewController

This allows the quick and easy change of the required numberOfTouches for swiping a page.

@uias-bot
Copy link
Member

uias-bot commented Aug 3, 2019

1 Warning
⚠️ Looks like you changed some source files, should there have been some tests added?

Generated by 🚫 Danger

msaps
msaps requested changes Aug 3, 2019
View reviewed changes
Copy link
Member

@msaps msaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Couple of questions 👍

Sources/Pageboy/PageboyViewController.swift Outdated Show resolved Hide resolved
Sources/Pageboy/PageboyViewController.swift Show resolved Hide resolved
Sources/Pageboy/PageboyViewController.swift Show resolved Hide resolved
@ChristianSteffens
Copy link
Contributor Author

Changes applied.

@msaps msaps merged commit 1ba7b33 into uias:master Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msaps msaps msaps requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristianSteffens @uias-bot @msaps