ICMSLST-2135 - Gov Notify #1149
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1149 +/- ##
==========================================
+ Coverage 75.43% 75.53% +0.09%
==========================================
Files 256 261 +5
Lines 18219 18289 +70
Branches 2928 2936 +8
==========================================
+ Hits 13744 13814 +70
Misses 4021 4021
Partials 454 454
☔ View full report in Codecov by Sentry. |
| @@ -1,5 +1,5 @@ | |||
| boto3==1.21.29 | |||
| celery[redis]==5.2.7 | |||
| celery[redis]==5.3.1 | |||
There was a problem hiding this comment.
Came across this issue during testing celery/billiard#377 Upgrading celery fixed the problem
| @@ -26,6 +25,7 @@ notifications-python-client==8.0.1 | |||
| openpyxl==3.0.7 | |||
| oracledb==1.2.0 | |||
| phonenumbers==8.12.12 | |||
| pytz==2023.3 | |||
There was a problem hiding this comment.
Was a dependancy of celery 5.2.7 and not 5.3.1. Is used by add_commodity_data script
| @@ -228,6 +223,7 @@ | |||
| CELERY_ACCEPT_CONTENT = ["application/json"] | |||
| CELERY_RESULT_SERIALIZER = "json" | |||
| CELERY_TASK_SERIALIZER = "json" | |||
| CELERY_RESULT_EXTENDED = True | |||
There was a problem hiding this comment.
Adding this takes care of logging (Ticket ICMSLST-2031). All tasks are logged in TaskResult object and this setting adds the task args and traceback information on failure. Is all viewable in django admin
| } | self.get_context() | ||
|
|
||
| def get_template_id(self) -> UUID: | ||
| return EmailTemplate.objects.get(name=self.name).gov_notify_template_id |
There was a problem hiding this comment.
Don't think it will be a problem but this will hit the db everytime any derived class is initialised.
Initial implementation of Gov Notify
django-celery-resultsdjango-ses