-
-
Notifications
You must be signed in to change notification settings - Fork 16.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Something about the code smell #57
Comments
Hello @rockyzhengwu, thank you for your interest in our work! Please visit our Custom Training Tutorial to get started, and see our Jupyter Notebook , Docker Image, and Google Cloud Quickstart Guide for example environments. If this is a bug report, please provide screenshots and minimum viable code to reproduce your issue, otherwise we can not help you. If this is a custom model or data training question, please note that Ultralytics does not provide free personal support. As a leader in vision ML and AI, we do offer professional consulting, from simple expert advice up to delivery of fully customized, end-to-end production solutions for our clients, such as:
For more information please visit https://www.ultralytics.com. |
@rockyzhengwu thanks for your feedback! You are right that the code could use some cleanup. Best practices is to drop code into functions when it repeated elsewhere, but in this case I believe this is the only location this code block is used. In any case there is improvement that could be made in variable naming and error checking in this code region like you mention. |
thanks for your work first
I just start to read the code in
utils/datasets.py
, May be can give you some advice about the code, you can just ignore this or think about it.some example
1, may be this can use a function not just write in the init ,
like this
ar
toaspect_ratio
not comment behindthere are some other like this two, but i think this is not import ,
in fact , i'm not sure if i want to summit this issues , because i also not write clean code.
The text was updated successfully, but these errors were encountered: