wip: switch to ProConnect #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🌟 Do we keep both for now? |
|
Not really, in the sense that only ProConnect will be exposed. I thought we could keep the possibility to rollback for a few days, just in case. But we could also just remove the MonComptePro backend, and revert it in case of urgency. |
yohanboniface
commented
Oct 3, 2024
| @@ -2,6 +2,19 @@ | |||
| --color-darkBlue: rgb(0, 0, 145); | |||
| } | |||
|
|
|||
| .login-proconnect { | |||
There was a problem hiding this comment.
Is that CSS used somewhere at the end ? I did not find the MonComptePro button.
There was a problem hiding this comment.
It's in use at https://umap.incubateur.anct.gouv.fr/en/login/ when you try to save a map without being logged in first.
There was a problem hiding this comment.
The class is generated here https:/umap-project/umap/blob/master/umap/templates/registration/login.html#L59
There was a problem hiding this comment.
Thanks! It works then :)
yohanboniface
force-pushed
the
proconnect
branch
from
0f899e5
to
89bf891
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.