Fixes with umb-route-slot
inside routed modal
#2146
+357
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This provides a potential fix for the issue described here: umbraco/Umbraco-CMS#16834
I'm thinking that the problem might be that the event that is fired when the route changes fires before the
umb-route-slot
inside the modal has been loaded. I tried some hacks withsetTimeout
to trigger the "routes"-attribute to re-load the routes in the modal. This worked so i figured that maybe if we set the routes of the underlyingrouter-slot
when a new route is loaded it might solve the problem.I made a small change to the
firstUpdated
method ofUmbRouterSlotElement
and after this, the scenario that I was having trouble with works.Types of changes
Motivation and context
How to test?
I've also added a example-folder to the PR, so just run
And pick
modal routed
Checklist