Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: inline editing mode for Block List Editor #2215

Merged
merged 19 commits into from
Aug 21, 2024

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Aug 16, 2024

Fixes umbraco/Umbraco-CMS#16298
Fixes umbraco/Umbraco-CMS#16777

This PR includes:

  • Making the Inline Editing mode for Block List Editor work again.
  • As well making the styling and interaction(use keyboard to open block) more appropriate.
  • Use ContentType Icon for both Inline and not Inline mode.

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@nielslyngsoe nielslyngsoe changed the title fix inline editing mode for Block List Editor Fix: inline editing mode for Block List Editor Aug 16, 2024
@leekelleher leekelleher self-requested a review August 19, 2024 11:16
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out, working great! 🚀

Removed unused import variables
Copy link

sonarcloud bot commented Aug 21, 2024

@nielslyngsoe nielslyngsoe merged commit 1c8c812 into main Aug 21, 2024
8 checks passed
@nielslyngsoe nielslyngsoe deleted the v14/bugfix/block-list-inline-editing branch August 21, 2024 11:14
@Nuklon
Copy link

Nuklon commented Sep 26, 2024

This isn't working correctly as UFM isn't rendered.

@bganser
Copy link

bganser commented Oct 11, 2024

This isn't working correctly as UFM isn't rendered.

I can confirm that UFM isn't working properly when inline editing is activated. Tested with a property with the alias "headline":
{=headline} was rendered in Blocklist as {=headline}.

umbraco_blocklisteditor_inlineediting

And live editing mode seems also not to be working (no matter if inline editing is activated or not).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Umbraco 14 - Block List inline editing mode do not work V14-RC3: BlockList inline editing mode does not work
5 participants