Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Only render a single Custom view + example with settings #2236

Merged
merged 6 commits into from
Aug 30, 2024
Merged

feature: Only render a single Custom view + example with settings #2236

merged 6 commits into from
Aug 30, 2024

Conversation

nielslyngsoe
Copy link
Member

Includes:

  • Makes Extension slot have a single attribute/property that can be set to limit its render to only one. + Unit tests for this
  • Fixes so we only render one custom view for a block.
  • Example updated to use settings data.

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 28, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
76.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@madsrasmussen madsrasmussen self-assigned this Aug 30, 2024
madsrasmussen
madsrasmussen approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@madsrasmussen madsrasmussen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@nielslyngsoe nielslyngsoe merged commit 700a6fb into main Aug 30, 2024
7 of 8 checks passed
@nielslyngsoe nielslyngsoe deleted the v14/feature/block-custom-view-example-with-settings branch August 30, 2024 06:44
@madsrasmussen madsrasmussen removed their assignment Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsrasmussen madsrasmussen madsrasmussen approved these changes

Assignees
No one assigned
Labels
category/documentation release/14.3.0 type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielslyngsoe @madsrasmussen