Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Readonly mode for Markdown Property Editor UI #2241

Merged
merged 5 commits into from
Aug 30, 2024

Conversation

madsrasmussen
Copy link
Contributor

Description

This PR adds readonly mode to the Markdown Property Editor UI

How to test

  • Add the readonly attribute to the element through developer tools

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, and it works. But sadly the Markdown editors readonly mode is more like a disabled state to me.. But I think its okay to accept that for now.

Copy link

sonarcloud bot commented Aug 30, 2024

@nielslyngsoe nielslyngsoe merged commit 1b1bc54 into main Aug 30, 2024
8 checks passed
@nielslyngsoe nielslyngsoe deleted the v14/feature/readonly-markdown-property-editor branch August 30, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants