Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Prevent publishing of readonly cultures #2298

Merged
merged 10 commits into from
Sep 17, 2024

Conversation

madsrasmussen
Copy link
Contributor

@madsrasmussen madsrasmussen commented Sep 16, 2024

Description

Note

Test against this branch with backend updates if it hasn't been merged: umbraco/Umbraco-CMS#17052

This PR prevents the publishing of read-only cultures. The issue is fixed on a couple of levels:

  • Add the possibility of setting a disallow compare function on the selection manager to prevent the selection of specific items.
  • Filter out read-only variant options before they are preselected in the publish dialogs.

The fix covers:

  • Save and publish
  • Publish with descendants
  • Schedule

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@nielslyngsoe nielslyngsoe merged commit 9e3555b into main Sep 17, 2024
8 checks passed
@nielslyngsoe nielslyngsoe deleted the 14/bugfix/only-publish-writebale-cultures branch September 17, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants