fix: Add whitespace when appending/prepending icon in uui-input #408
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When rendering an icon in the prepend or append slot in the uui-input component, the icon was lacking whitespace:
Changes here add whitespace (Append example has inline background color and left-padding):
For simplicity, the icon has a left-margin when prepended, and a right margin when appended, to move it off the input edge in both cases. Additional styling would need to depend on the context (ie an appended icon with a background color would need additional padding on the left side to separate the input text), which would need to be managed in the specific implementation.
Vertical alignment relies on the icon not being slotted directly, but using an enclosing element (this is the existing behaviour before this change):
Types of changes