uui-color-swatches: color swatches changes form when showLabel is true #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielslyngsoe
approved these changes
Mar 8, 2023
|
@loivsen is seems there is a test failing. Will you have a look at it?.. I have approved it, so once it goes through it should be merged. :-) |
iOvergaard
changed the title
iOvergaard
added a commit
that referenced
this pull request
Apr 20, 2023
…is true (#427) * Color swatches changes form when showLabel is true --------- Co-authored-by: Niels Lyngsø <[email protected]> Co-authored-by: Jacob Overgaard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Color swatches changes form when showLabel is set to true.
Added logic for overflow on swatches labels
Color swatches are now an actual button
Removed extra padding for swatches
Added padding for color picker's swatch area