uui-range-slider overhaul #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, didn't see this was a draft PR. Waiting to see what happens with it :) |
…e-slider-overhaul
iOvergaard
changed the title
iOvergaard
added a commit
that referenced
this pull request
Apr 20, 2023
* range-slider overhaul * tests * block * add .nvmrc to indicate which node version to use * increase memory on build tasks --------- Co-authored-by: Jacob Overgaard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The range slider had a number of problems with z-index and able to pick values outside the step setting or min/max gaps.
It was also one of the first things that I created, so the codebase was really difficult to read.
I've made this overhaul to fix the issues, as well as making an attempt to make the code a little more readable.
There shouldn't be any breaking changes.
Things to keep in mind: