Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filemanager: consider using cargo-lambda-cdk instead of aws-cdk-lambda #133

Closed
mmalenic opened this issue Mar 4, 2024 · 3 comments · Fixed by #152
Closed

filemanager: consider using cargo-lambda-cdk instead of aws-cdk-lambda #133

mmalenic opened this issue Mar 4, 2024 · 3 comments · Fixed by #152
Assignees
Labels
filemanager an issue relating to the filemanager investigation Look into how best to approach the problem

Comments

@mmalenic
Copy link
Member

mmalenic commented Mar 4, 2024

This project is more up to date and maintained than the current aws-cdk-lambda that filemanager uses. It also seems to have slightly simpler configuration, so we should investigate whether it's worthwhile to switch.

@mmalenic mmalenic added investigation Look into how best to approach the problem filemanager an issue relating to the filemanager labels Mar 4, 2024
@mmalenic
Copy link
Member Author

mmalenic commented Mar 6, 2024

cargo-lambda-cdk also supports bundling the Lambda code using docker, which is convenient for CodeBuild because there is no requirement to install Rust or cargo lambda.

@mmalenic
Copy link
Member Author

mmalenic commented Mar 7, 2024

@brainstorm might be able to remove those query_* files by using the before command hook to run the local database when building with cargo-lambda-cdk: https:/cargo-lambda/cargo-lambda-cdk?tab=readme-ov-file#command-hooks

@brainstorm
Copy link
Member

@brainstorm might be able to remove those query_* files by using the before command hook to run the local database when building with cargo-lambda-cdk: https:/cargo-lambda/cargo-lambda-cdk?tab=readme-ov-file#command-hooks

Ohhh, yesyesyes!

@mmalenic mmalenic self-assigned this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filemanager an issue relating to the filemanager investigation Look into how best to approach the problem
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants