Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filemanager: remove database requirement to compile code #530

Closed
mmalenic opened this issue Sep 3, 2024 · 0 comments · Fixed by #534
Closed

filemanager: remove database requirement to compile code #530

mmalenic opened this issue Sep 3, 2024 · 0 comments · Fixed by #534
Assignees
Labels
filemanager an issue relating to the filemanager refactor

Comments

@mmalenic
Copy link
Member

mmalenic commented Sep 3, 2024

We should consider removing the requirement on a postgres database to compile code. While this was initially a good feature in early development, I think it's not that useful anymore and tends to get in the way as most tools just don't expect code compilation to require database access. See #429 and #529.

This would involve turning any sqlx query! calls into function calls using query(), as these don't require database access. It would also mean removing the filemanager-build sea-orm entity generation step and instead adding the generated entities into the code base.

I think this change would be beneficial, as it would reduce the hassle of compiling the filemanager codebase and also probably improve compile times.

@mmalenic mmalenic self-assigned this Sep 3, 2024
@mmalenic mmalenic added filemanager an issue relating to the filemanager refactor labels Sep 3, 2024
@umccr umccr deleted a comment Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filemanager an issue relating to the filemanager refactor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant