Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event duplication And Remove Server access logs when archiving to bucket #247

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

raylrui
Copy link
Contributor

@raylrui raylrui commented Apr 23, 2024

  1. Fix Prevent event duplication when archiving to bucket #244
    fix logger info format error in lambda

Duplicate Event Reason:
From the cloud watch log about this func, we have error in logger.info , and the error isError storing event: not all arguments converted during string formatting, this may come the %s is a placeholder that expects a string to replace in the info.
image

And this error will trigger retry function in our setting. Retry 3 times will generate 3 copy of the events.

  1. Fix Evaluate need for S3 access log retention in event-archive-bucket #245
    As I check around for our could trail events, we may not need the to retain the server access logs for event archiver bucket, as the main purpose for this bucket is to "archive" already, and serve for event statistic and analysis.

PS: add cdk-nag Suppressions for unit testing error for the s3 bucket:
["AwsSolutions-S1: The S3 Bucket has server access logs disabled. [/SharedStack/EventBusConstruct/UniversalEventArchiveBucket/Resource]"]

@raylrui raylrui marked this pull request as ready for review April 23, 2024 05:11
@raylrui raylrui self-assigned this Apr 23, 2024
@raylrui raylrui requested a review from reisingerf April 23, 2024 05:12
@raylrui raylrui changed the title Fix event duplication when archiving to bucket Fix event duplication when archiving to bucket And Remove Server access logs Apr 23, 2024
@raylrui raylrui changed the title Fix event duplication when archiving to bucket And Remove Server access logs Fix event duplication And Remove Server access logs when archiving to bucket Apr 23, 2024
@raylrui raylrui merged commit 1548e0a into main Apr 23, 2024
2 checks passed
@raylrui raylrui deleted the feature/universal-event-archiver branch April 23, 2024 06:23
@raylrui raylrui restored the feature/universal-event-archiver branch April 23, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants