custom event bus archiver props and stateful unit testing fixing #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reviewing... |
victorskl
approved these changes
Apr 29, 2024
|
As this PR will not create any new resource and change current resource, just refactor current props and unit testing issues, I will merge it first... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for custom event bus archiver:
refactor current event bus archiver props with new
EventBusArchiverPropsfor clarity and granular manipulation, and also enable eventbus props for future extension with more special archivers.fixing stateful unit testing error with new name conventions in
eventbusConstruct.test.ts